rhtyd commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming
convention in case vmware is used
URL: https://github.com/apache/cloudstack/pull/1302#discussion_r113885986
##########
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3383,12 +3383,6 @@ protected UserVm createVirtualMachine(DataCenter zone,
ServiceOffering serviceOf
hostName = generateHostName(uuidName);
}
}
- // If global config vm.instancename.flag is set to true, then CS
will set guest VM's name as it appears on the hypervisor, to its hostname.
- // In case of VMware since VM name must be unique within a DC,
check if VM with the same hostname already exists in the zone.
Review comment:
Instead of removing the check, does it make sense to amend it to verify that
with the updated naming convention -- there are no duplicate VMs by name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
