Github user anshul1886 commented on the issue:

    https://github.com/apache/cloudstack/pull/793
  
    @koushik-das @sateesh-chodapuneedi @ramkatru @karuturi @rhtyd  Regarding 
unit tests, I can't see any useful tests can be written here which I have 
already specified the reason for. Also we have already lot of unit tests which 
are wasting time to fix. Every now and then I am coming across unit tests which 
are not written in proper way and leads to waste of effort. As far as my 
understanding of unit test goes they are to reduce effort not increase. One 
example is in this PR's last jenkins run. That build was failed because one 
test is trying to download/copy file and that failed. As per my understanding 
unit tests should not do any thing which are dependent on external environments 
failure. As those kind of failures are bound to happen. As when those happen we 
have to go and check why that is failed wasting some time to understand. So 
ultimately we are wasting lot of effort currently because of tests not properly 
written.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to