GitHub user ProjectMoon opened a pull request:

    https://github.com/apache/cloudstack/pull/1943

    CLOUDSTACK-9339: Send correct network type to router config

    This forces the network type (nw_type) of the IP address being sent into 
router configuration scripts to be lowercase. All of the Python config scripts 
on the router explicitly look for network type "public" with a lowercase P. 
Sending "Public" with an uppercase P can cause important iptables rules to not 
be created, meaning that public networking won't work.
    
    We discovered this while applying the other fix for CLOUDSTACK-9339 to our 
own 4.7 branch, and then checked master and saw that it hadn't been changed 
yet. The fix is very simple: force the network type to lowercase when creating 
IpAssoc config items. Without this fix, iptables rules for public IPs that are 
added in `CsAddress.py` would get skipped, and traffic into instances on 
interfaces other than eth2 would not work.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack pr-lowercase-p

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1943
    
----
commit 163b9c76be06d8d3e019b9826900a0135437dfaa
Author: jeff <j...@greenqloud.com>
Date:   2017-02-13T16:17:25Z

    CLOUDSTACK-9339: Send correct network type to router config
    
    This forces the network type (nw_type) of the IP address being sent
    into router configuration scripts to be lowercase. All of the Python
    config scripts on the router explicitly look for network type "public"
    with a lowercase P. Sending "Public" with an uppercase P can cause
    important iptables rules to not be created, meaning that public
    networking won't work.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to