Github user swill commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1907#discussion_r101062037
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
             gw = interface.get_gateway()
             logging.info("Interface has the following gateway ==> %s", gw)
     
    -        if bag['nw_type'] == "guest" and rip == gw:
    +        guest_gw = self.config.cmdline().get_guest_gw()
    +        logging.info("Interface has the following gateway ==> %s", 
guest_gw)
    +
    +        if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
    --- End diff --
    
    @ustcweizhou I am not sure that changes removes the need for this, but it 
looks like it could potentially.  Maybe I can run some tests to see if it can 
be removed given #1871 has been merged...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to