At this point, I think 1741 is ready to merge. I think we need one more LGTM though...
*Will STEVENS* Lead Developer <https://goo.gl/NYZ8KK> On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens <wstev...@cloudops.com> wrote: > @Daan: In order for the tests to pass with 1741, the tests have to be run > with the SystemVM from the PR being used. > > *Will STEVENS* > Lead Developer > > <https://goo.gl/NYZ8KK> > > On Wed, Feb 8, 2017 at 2:46 AM, Daan Hoogland <daan.hoogl...@gmail.com> > wrote: > >> About 1741, I started the packaging, Will but saw Boris making a >> remark about the system VMs. I'll look into that and start the tests. >> >> On Tue, Feb 7, 2017 at 8:19 PM, Will Stevens <williamstev...@gmail.com> >> wrote: >> > I would like to get 1741(strongswan) in, but I need to get Trillian to >> run >> > against it with a system vm built from my pr. I have done a CI in bubble >> > and it came back clean, but would like confirmation through Trillian as >> > well. >> > >> > On Feb 7, 2017 2:17 PM, "Milamber" <milam...@apache.org> wrote: >> > >> >> >> >> And this PR for 4.9 but need to be foward to 4.10 too. >> >> >> >> https://github.com/apache/cloudstack/pull/1929 >> >> >> >> 2 LGTM >> >> CI green >> >> >> >> >> >> On 07/02/2017 13:07, Rajani Karuturi wrote: >> >> >> >>> Hi all, >> >>> If you know of any PRs which meet the below criteria, please mail >> them to >> >>> me. >> >>> 1. No open questions. >> >>> 2. Has two LGTMs >> >>> 3. Has CI test results. >> >>> >> >>> ~Rajani >> >>> http://cloudplatform.accelerite.com >> >>> >> >>> >> >> >> >> >> >> -- >> Daan >> > >
