Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1735#discussion_r94659104
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -526,16 +529,18 @@ public static DataStoreRole getDataStoreRole(Snapshot
snapshot, SnapshotDataStor
}
long storagePoolId = snapshotStore.getDataStoreId();
- DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId,
DataStoreRole.Primary);
--- End diff --
Another possibility here is that we could simply still try to retrieve
"dataStore" and then perform this check:
DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId,
DataStoreRole.Primary);
if (dataStore == null) {
return DataStoreRole.Image;
}
If "dataStore" equals null, then it was removed, which should only be
something that happened when unmanaged storage is being used (thus when the the
snapshot resides on secondary storage).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
