Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1899#discussion_r95524178
  
    --- Diff: api/src/com/cloud/deploy/DeploymentClusterPlanner.java ---
    @@ -55,7 +55,7 @@
                 "true",
                 "Enable/Disable cluster thresholds. If disabled, an instance 
can start in a cluster even though the threshold may be crossed.",
                 false,
    -            ConfigKey.Scope.Zone);
    +            ConfigKey.Scope.Global);
    --- End diff --
    
    This refers to cluster level setting, admins should be allowed to override 
this at the cluster level. Please change this to ConfigKey.Scope.Cluster.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to