Syed,
The aim of this PR #1807 is to avoid breaking upgrades for users. With introduction of your PR (#1600), an extension was seen to be added to snapshot files. The PR I've shared removes '.vhd' extension from the snapshot file names, while regression smoke tests against XenServer65sp1 seem to be passing -- we're not sure if this will have any side-effects in your code (i.e. changes from your PR#1600). Can you validate and review the PR and run tests on your side (i.e. test master branch including PR#1807)? If we fail to do that this week, otherwise to avoid further delaying the release work we'll have to revert your previous PR merge (#1600), request you to submit it again. Regards. ________________________________ From: Syed Ahmed <sah...@cloudops.com> Sent: 06 December 2016 10:20:45 To: dev@cloudstack.apache.org Subject: Re: [GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ... I see. I was more interested in the functionality that is broken on Cloudstack. I have verified that older operations are still working correctly. Did I miss anything? On Mon, Dec 5, 2016 at 23:44 Abhinandan Prateek < abhinandan.prat...@shapeblue.com> wrote: > Syed, > > Any test that is calling is_snapshot_on_nfs from utils.py will fail for > Xen as it ends up appending an additional “.vhd” to the install_path. There > are several of them both in smoke and component folder. The reason this is > under scrutiny is die to marvin test failures. > > > > On 06/12/16, 9:33 AM, "Syed Ahmed" <sah...@cloudops.com> wrote: > > >Yes this will break managed snapshot archives. I want to understand what > >this revert is trying to fix and what tests were failing. > >On Mon, Dec 5, 2016 at 22:38 abhinandanprateek <g...@git.apache.org> > wrote: > > > >> Github user abhinandanprateek commented on the issue: > >> > >> https://github.com/apache/cloudstack/pull/1807 > >> > >> @syed can you look at this 'revert' i guess this is going to be an > >> issue with the managed storage change that has been put in. cc @rhtyd > >> > >> > >> --- > >> If your project is set up for it, you can reply to this email and have > your > >> reply appear on GitHub as well. If your project does not have this > feature > >> enabled and wishes so, or if the feature is enabled but not working, > please > >> contact infrastructure at infrastruct...@apache.org or file a JIRA > ticket > >> with INFRA. > >> --- > >> > > abhinandan.prat...@shapeblue.com > www.shapeblue.com<http://www.shapeblue.com> > 53 Chandos Place, Covent Garden, London WC2N 4HSUK > @shapeblue > > > > rohit.ya...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue
