Github user ppenchev-storpool commented on the issue:
https://github.com/apache/cloudstack/pull/1780
Hi,
Thanks for looking at this!
Testing this could simply be a matter of adding more than one storage
adaptor to a KVM storage pool, then connecting and disconnecting physical
disks. The problem will only manifest itself when disconnecting a disk that is
not handled by the iSCSI provider if the loop in
KVMStoragePoolManager.disconnectPhysicalDiskByPath() (file
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java
around line 161) finds the iSCSI adaptor first. Well, yeah, making sure the
loop finds the iSCSI adaptor first may not be easy if Java orders the map keys
almost randomly, but with some luck and/or some changes to the loop itself it
could be arranged (change only the order in which the entries are walked, not
the processing of the entries themselves).
BTW, this is actually the *only* place where the adaptor's
disconnectPhysicalDiskByPath() method is invoked, so just analyzing the code
there should show that this change ought to be safe.
Best regards,
Peter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
