Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87837783
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -489,9 +490,11 @@ def checkVolumeSize(ssh_handle=None,
return FAILED
for line in fdisk_output["stdout"]:
if volume_name in line:
- parts = line.strip().split()
- if str(parts[-2]) == str(size_to_verify):
- return [SUCCESS,str(parts[-2])]
+ # Get the bytes from the output
+ # Disk /dev/xvdb: 1 GiB, 1073741824 bytes, 2097152
sectors
+ m = re.match('.*?(\d+) bytes.*', line)
--- End diff --
Minor nit: `m` is not a descriptive/Pythonic variable. Please consider
refactoring a more a descriptive name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
