I think that it would be very interesting Simon. Do you have something in
mind?
*(After a fast brainstorming)*
The only common point for all hypervisors is the
*com.cloud.resource.ServerResource* interface. All hypervisors implement
(or extend some class that implements) this interface. However, the
ServerResource is also implemented by non-hypervisors (e.g.
*com.globo.globodns.cloudstack.resource.GloboDnsResource*).
Should we consider creating some "abstraction" level just for hypervisors?
Such class/interface would have a method for enabling specific features
according to the deployed virtual machine OS.
Cheers,
Gabriel.
2016-10-05 13:53 GMT-03:00 Simon Weller <swel...@ena.com>:
> This is one area, in my opinion, we just need to redesign.
>
> It would be nice to have customized OS offeringss, with a feature list
> that can be enabled in regards to the hypervisor per profile.
>
>
> - Si
>
>
> ________________________________
> From: Andrija Panic <andrija.pa...@gmail.com>
> Sent: Wednesday, October 5, 2016 11:46 AM
> To: dev@cloudstack.apache.org
> Cc: Voloshanenko Igor; Dmytro Shevchenko
> Subject: Re: jira 8535 opinion please
>
> BTW, based on the code, I guess this only support host OS being
> centos/redhat 6.5+ and 7+ ? We need to expand this code to cover Ubuntu
> 14.04 as well I guess.
>
> cheers
>
> On 5 October 2016 at 18:44, Andrija Panic <andrija.pa...@gmail.com> wrote:
>
> > Hi Gabriel,
> >
> > I'm personally not familiar with any code :) but that is the reaason my
> > colegues are in CC here.
> >
> > What I believe I miss here (please correct me if I'm wrong) is the same
> > hyperV relaxed feature for also "Windows 7" OS type (although not that
> > important) but also for "Windows PV" OS type, since we run our customers
> > VMs with virtio, and we need to choose "Windows PV" to actually use
> virtio
> > paravirtalization on KVM side.
> >
> > Thanks a lot for the specific code, I believe this is a good starting
> > point for us - and please feel free to correct me in my opinions.
> >
> > Thanks again,
> > Andrija
> >
> > On 5 October 2016 at 14:59, Gabriel Beims Bräscher <gabrasc...@gmail.com
> >
> > wrote:
> >
> >> Hi Andrija,
> >>
> >> Seems that this issue has been forgotten for a while, thanks for
> bringing
> >> it back.
> >>
> >> I did a fast review on the code (current Apache CloudStack master) and
> >> found something that might be useful.
> >> The method
> >> com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.c
> >> reateVMFromSpec(VirtualMachineTO)
> >> has some commented lines when adding features (lines 1947-1953), those
> >> lines were supposed to set the HyperV relaxed feature in case of Windows
> >> Server 2008.
> >>
> >> /*
> >> * if (vmTO.getOs().contains("Windows Server 2008") &&
> >> hostOsVersion != null && ((hostOsVersion.first() == 6 &&
> >> hostOsVersion.second() >= 5) || (hostOsVersion.first() >= 7))) {
> >> * LibvirtVMDef.HyperVEnlightenmentFeatureDef hyv = new
> >> LibvirtVMDef.HyperVEnlightenmentFeatureDef();
> >> * hyv.setRelaxed(true);
> >> * features.addHyperVFeature(hyv);
> >> * }
> >> */
> >>
> >>
> >> Would it be a starting point? Are you familiar with this code?
> >>
> >> Cheers,
> >> Gabriel.
> >>
> >> 2016-10-04 5:52 GMT-03:00 Andrija Panic <andrija.pa...@gmail.com>:
> >>
> >> > Hi,
> >> >
> >> > may I please get anyones opinion on this:
> >> > https://issues.apache.org/jira/browse/CLOUDSTACK-8353
> >> >
> >> > We woul like to solve it internally and comit to comunity - just need
> >> some
> >> > opinions or advices.
> >> >
> >> > "There is a bug in KVM that causes a BSOD for Windows 2008 R2 and 7 or
> >> > earlier. fix was added in libvirt 1.1.1 The fix requires enabling the
> >> > "hv_relaxed" option for the affected VMs.
> >> > "
> >> >
> >> > thanks
> >> >
> >> > Andrija Panic
> >> >
> >>
> >
> >
> >
> > --
> >
> > Andrija Panic
> >
>
>
>
> --
>
> Andrija Panic
>
