GitHub user murali-reddy opened a pull request:

    https://github.com/apache/cloudstack/pull/1681

    CLOUDSTACK-9491: incorrect parsing of device list to find ethernet index of 
plugged NIC

    
    In VmwareResource, findRouterEthDeviceIndex() method find ethernet 
interface index given
    the mac address. This method is used, once a nic is plugged to determine 
ethernet interface.
    "/proc/sys/net/ipv4/conf" from the VR and looped through the devices to 
find the right
    ethernet interface. Howver current logic read it once, and loops through 
the device list.
    Its observerd device may not show up '/proc/sys/net/ipv4/conf' immediatly 
once NIC is plugged
    in the VM from vCenter.
    
    Fix ensured, while waiting for 15 sec in the loop, read the latest content 
from /proc/sys/net/ipv4/conf
    , so that right device list is processed.
    
    Manual tested VPC scenarios of adding new tiers which uses 
findRouterEthDeviceIndex, to find the guest/public network ethernet index.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/murali-reddy/cloudstack 
router_eth_device_index

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1681
    
----
commit be7ade3153d3b29c18d904d5327c1af139e1c037
Author: Murali Reddy <muralimmre...@gmail.com>
Date:   2016-09-21T06:08:47Z

    CLOUDSTACK-9491: incorrect parsing of device list to find ethener index of 
plugged nic
    
    In VmwareResource, findRouterEthDeviceIndex() method find ethernet 
interface index given
    the mac address. This method is used, once a nic is plugged to determine 
ethernet interface.
    "/proc/sys/net/ipv4/conf" from the VR and looped through the devices to 
find the right
    ethernet interface. Howver current logic read it once, and loops through 
the device list.
    Its observerd device may not show up '/proc/sys/net/ipv4/conf' immediatly 
once NIC is plugged
    in the VM from vCenter.
    
    Fix ensured, while waiting for 15 sec in the loop, read the latest content 
from /proc/sys/net/ipv4/conf
    , so that right device list is processed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to