Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1659#discussion_r76481464
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
    @@ -884,6 +884,13 @@ def processStaticNatRule(self, rule):
             device = self.getDeviceByIp(rule["public_ip"])
             if device is None:
                 raise Exception("Ip address %s has no device in the ips 
databag" % rule["public_ip"])
    +
    +        self.fw.append(["mangle", "",
    +                        "-A PREROUTING -s %s/32 -m state --state NEW -j 
MARK --set-xmark 0x%s/0xffffffff" % \
    +                        (rule["internal_ip"], device[len("eth"):])])
    +        self.fw.append(["mangle", "",
    +                        "-A PREROUTING -s %s/32 -m state --state NEW -j 
CONNMARK --save-mark --nfmask 0xffffffff --ctmask 0xffffffff" % \
    --- End diff --
    
    Is there value in extracting the ``0xffffffff`` to a constant?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to