Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1660#discussion_r76477326
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String
user, File pemKeyFile, St
}
String result = sbResult.toString();
+ if (result == null || (result != null && result.isEmpty())){
+ int stdOutAvailable = stdout.available();
+ while (stdOutAvailable != 0){
+ currentReadBytes = stdout.read(buffer);
+ sbResult.append(new String(buffer, 0,
currentReadBytes));
+ stdOutAvailable = stdout.available();
+ }
+ result = sbResult.toString();
--- End diff --
Consider replacing lines 199-205 with the following:
```
result = IOUtils.toString(buffer, Charset.defaultCharset());
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
