Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1653#discussion_r75690054
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -452,9 +452,9 @@ def fw_vpcrouter(self):
self.fw.append(
["filter", "", "-A INPUT -i %s -p udp -m udp --dport 67 -j
ACCEPT" % self.dev])
self.fw.append(
- ["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -j
ACCEPT" % self.dev])
+ ["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -s
%s -j ACCEPT" % (self.dev, self.address['network'])])
self.fw.append(
- ["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -j
ACCEPT" % self.dev])
+ ["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -s
%s -j ACCEPT" % (self.dev, self.address['network'])])
--- End diff --
Minor nit: extract the value of ``self.address['network']`` to a local
variable? Not only will change ensure consistency of the value across the four
rules, but it will make the code more literate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
