I disagree with having only RMs to merge PRs when we're not in freeze. In general we've implicitly honoured this behaviour but it was never voted. Our RMs may not be as active as we want them to be, while they are historically good at writing policies but it's hard to put them in practice and further it's understandable that they may not be able to volunteer enough time and effort to get the PRs sorted.
Over past months this and similar practices have killed our commit and development momentum, and I think it's not a healthy practice for our community to engage in further. Instead, we can have committers (and in future maybe bots) to merge a PR if they have 2 LGTMs, no objections and test results from both Travis (simulator) and Bubble/BVT/Trillian (tests against at least one and ideally all three hypervisors - KVM, Xen and VMware). Regards. ________________________________ From: Rajani Karuturi <raj...@apache.org> Sent: 03 August 2016 13:43:54 To: dev@cloudstack.apache.org Subject: Re: 4.10.0 release ouch.. looks like my email client stripped all the new lines. Re-sending from webmail Hi All, These are the proposed dates for 4.10 release (copied from another thread by John Burwell) * Development (master open to features and defect fixes): 1 August 2016 - 11 September 2016 * Testing: 12 - 18 September 2016 * RC Voting: 19 - 25 September 2016 * Release: 26 September 2016 master is open for 4.10.0. It still means that only PRs will be merged and they will be merged only by RMs ( For 4.10.0, its John Burwell and Rajani Karuturi) Every PR should have a JIRA bug ID, 1 code review and 1 test review. It would help in reviewing if the contributor could put information about the feature/bug and how its tested. Also, please rebase any pending PRs you have to the latest master or the 4.9 release branch. Finally, anyone in the community can review and test PRs. We currently have huge backlog. We need everyones help in getting them merged(especially running the tests) Looking forward for your help in merging PRs. Happy PR bashing!! Thanks, ~Rajani rohit.ya...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue On Wed, Aug 3, 2016 at 1:19 PM, Erik Weber <terbol...@gmail.com> wrote: > A newline or two wouldn't hurt, this is pretty hard to read tbh. > > -- > Erik > > On Wed, Aug 3, 2016 at 9:27 AM, Rajani Karuturi <raj...@apache.org> wrote: > > > Hi All,These are the proposed dates for 4.10 release (copied from > > another thread by John Burwell)* Development (master open to > > features and defect fixes): 1 August 2016 - 11 September 2016* > > Testing: 12 - 18 September 2016* RC Voting: 19 - 25 September > > 2016* Release: 26 September 2016 > > master is open for 4.10.0. It still means that only PRs will be > > merged and they will be merged only by RMs ( For 4.10.0, its John > > Burwell and Rajani Karuturi)Every PR should have a JIRA bug ID, 1 > > code review and 1 test review.It would help in reviewing if the > > contributor could put information about the feature/bug and how > > its tested.Also, please rebase any pending PRs you have to the > > latest master or the 4.9 release branch. > > Finally, anyone in the community can review and test PRs. We > > currently have huge backlog. We need everyones help in getting > > them merged(especially running the tests)Looking forward for your > > help in merging PRs. Happy PR bashing!! > > Thanks,~ Rajanihttp://cloudplatform.accelerite.com/ >
