Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-218869277
@DaanHoogland I agree we have some strange patterns in the codebase. For
this feature, I simply followed those patterns when I saw them because I wasn't
sure why they were coded that way (maybe for AOP?) and was afraid to deviate
from it unless I better understood why it was the way it was in the first place
(for example, some "Void" return types instead of "void" return types).
I did make the changes you suggested, though, Daan. Hopefully there wasn't
any good reason in the first place why some of those Void return types were in
there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
