Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r61870927
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView
view, String objectName, Us
userVmResponse.setNetworkKbsWrite((long)vmStats.getNetworkWriteKBs());
- if ((userVm.getHypervisorType() != null) &&
(userVm.getHypervisorType().equals(HypervisorType.KVM) ||
userVm.getHypervisorType().equals(HypervisorType.XenServer))) { // support KVM
and XenServer only util 2013.06.25
+ if ((userVm.getHypervisorType() != null) &&
(userVm.getHypervisorType().equals(HypervisorType.KVM) ||
userVm.getHypervisorType().equals(HypervisorType.XenServer) ||
userVm.getHypervisorType().equals(HypervisorType.VMware))) { // support KVM and
XenServer only util 2013.06.25 . supporting Vmware from 2015.09.02
--- End diff --
@koushik-das, that is a great question.
I have no idea why we need to check the hypervisor type. This is something
that probably comes way before @maneesha-p changes, giving that she/he just
added the check for VMware.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
