Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61846972
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.outofbandmanagement;
+
+import com.cloud.dc.DataCenter;
+import com.cloud.host.Host;
+import com.cloud.org.Cluster;
+import com.google.common.collect.ImmutableMap;
+import org.apache.cloudstack.api.response.OutOfBandManagementResponse;
+import org.apache.cloudstack.framework.config.ConfigKey;
+
+import java.util.List;
+
+public interface OutOfBandManagementService {
+
+ ConfigKey<Long> OutOfBandManagementActionTimeout = new
ConfigKey<Long>("Advanced", Long.class, "outofbandmanagement.action.timeout",
"60",
+ "The out of band management action timeout in seconds,
configurable by cluster", true, ConfigKey.Scope.Cluster);
+
+ ConfigKey<Long> OutOfBandManagementSyncThreadInterval = new
ConfigKey<Long>("Advanced", Long.class, "outofbandmanagement.sync.interval",
"300000",
+ "The interval (in milliseconds) when the out-of-band
management background sync are retrieved", true, ConfigKey.Scope.Global);
+
+ ConfigKey<Integer> OutOfBandManagementSyncThreadPoolSize = new
ConfigKey<Integer>("Advanced", Integer.class,
"outofbandmanagement.sync.poolsize", "50",
+ "The out of band management background sync thread pool size",
true, ConfigKey.Scope.Global);
+
+ long getId();
+ boolean isOutOfBandManagementEnabled(Host host);
+ void submitBackgroundPowerSyncTask(Host host);
+ boolean transitionPowerStateToDisabled(List<? extends Host> hosts);
--- End diff --
There is nothing wrong with the code, it's a valid declaration and usage of
generics that accepts any list of concrete items that implement the Host
interface; and a classic usage of `PECS`
http://stackoverflow.com/questions/2723397/what-is-pecs-producer-extends-consumer-super
Once RBAC PR is merged, I'll use the ListUtils in there that would return a
List<Host> along with fix the validateParams with api annotation validators.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
