Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1408#issuecomment-216304156
@swill I've validated the lock logic in a gist above, I've tested the
elusiveness of critical code that runs when a lock is acquired; security groups
is implemented using ebtables (rules on bridges) therefore this script is run
at hypervisor host (kvm in this case, by the agent) -- the changes ensure that
no two executions of this script are allowed at the same time
as for prod testing, @wido can you comment on testing the changes in this
PR, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---