Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-211499145
@nv I am sorry, I might have seen the â@Localâ annotation in some other
PR, and I thought I have seen on yours.
The classes VMSnapshotManagerImpl and SnapshotManagerImpl are using
something from âManagerBaseâ?
I am ok with the static methods if there is no way to create a class
hierarchic. They are clean and well documented. I am only missing the test
cases for those two new methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
