Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59800096
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ---
@@ -117,6 +123,12 @@ public long getEntityOwnerId() {
@Override
public void execute() {
+ if (Strings.isNullOrEmpty(getCfgName())) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Empty
configuration name provided");
+ }
+ if
(getCfgName().equalsIgnoreCase(RoleService.EnableDynamicApiChecker.key())) {
+ throw new ServerApiException(ApiErrorCode.METHOD_NOT_ALLOWED,
"Restricted configuration update not allowed");
--- End diff --
Method Not Allowed (405) indicates the caller attempted to use an HTTP
method (i.e. GET, PUT, POST, DELETE) that is not allowed for the resource. In
this case, the method is allowed, but the parameters do not all the method to
be performed. Seems like ``PARAM_ERROR`` would be more appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
