Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-197948544 I understand that your point that some other classes can overwrite that method and may return other elements of the enum. However, I do not see anything else in the code that used the âcanHandleâ method return that uses the returned value. I mean, it is used in the ârevertSnapshotâ method at line 285, but it only checks if the return is equal to âStrategyPriority.CANT_HANDLEâ and then throws an exception if it is. To me, that is the same as if the method were returning a boolean value.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---