Sometimes they might seem old, but when interaction just sort of... stops, it can be hard to keep track of what is going on with the PRs. Currently we have 6 or 7 open PRs that no one has commented on or looked at in months. Two were recently updated with integration test results at least. One is missing a unit test that I still need to write, but the others are (were) ready to go. Every few weeks I go and rebase them and then they sit there for a few more weeks. Rinse, repeat it seems like...
What scope is needed for the testing? Is the plan to use some CI then manually test, in addition to the unit tests? Or are in some cases unit tests good enough? On Thu, Mar 17, 2016 at 9:18 PM, Remi Bergsma <rberg...@schubergphilis.com> wrote: > PRs needs to be tested obviously, that is the current impediment. The > moment you test a PR, you get current master and merge the PR and test that > result. Once it’s OK, merge it to master and take next one, etc. I wouldn’t > start rebasing, as you’ll have a lot of work and will need to keep doing > that. Git is pretty good in merging stuff so it will work quite often. Or > else result in some PRs not being able to merge due to conflicts. Those > need to be resolved. > > Another thing: I would say 50% (if not more) is never going to be merged > because they’re too old, abandoned, broken, etc. > > Regards, > Remi > > > > > > On 17/03/16 22:10, "Simon Weller" <swel...@ena.com> wrote: > > >If we ask for each PR to be rebased with master, we need to commit as a > team to actually working through them rapidly, as obviously rebasing is > significant work in a lot of cases. > > > >Just my 2 cents. > > > >- Si > > > > > > > > > >________________________________________ > >From: ilya <ilya.mailing.li...@gmail.com> > >Sent: Thursday, March 17, 2016 4:06 PM > >To: dev@cloudstack.apache.org > >Subject: [IMPORTANT] Huge Github PR Backlog > > > >Hi Folks, > > > >What can we do about PR backlog in GitHub? As we all know, it will be > >very difficult to merge the changes - as things will get out of sync. > > > >Feedback is welcome, > > > >Thanks, > >ilya >
