Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1437#issuecomment-195095474
  
    @eriweb
    There are things that do not need to be tested, we work in computer 
science; if there is no reference to an object/class, there is no way it is 
being used.
    
    The only reference for that class name is in a log at line 250 of class 
“com.cloud.hypervisor.hyperv.discoverer.HypervServerDiscoverer”, the log 
says that it is creating the dummyResource, however, it creates the 
“com.cloud.hypervisor.hyperv.resource.HypervDirectConnectResource” at line 
282.
    
    This is a fair and simple removal of unused code/class. @pedro-martins , 
could you also fix the log message in “HypervServerDiscoverer” at line 250?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to