Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r52953884
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,6 +195,12 @@ private void validate(SnapshotInfo snapshotInfo) {
}
}
+ private boolean usingBackendSnapshotFor(SnapshotInfo snapshotInfo) {
+ String property = getProperty(snapshotInfo.getId(),
"takeSnapshot");
+
+ return Boolean.parseBoolean(property);
+ }
+
private Void handleCreateTemplateFromSnapshot(SnapshotInfo
snapshotInfo, TemplateInfo templateInfo,
AsyncCompletionCallback<CopyCommandResult> callback) {
--- End diff --
Thanks. Initially this method was patterned off of an existing set of
methods that used the "Void" approach. I wasn't sure if there was a good reason
for why they did it that way and erred on the side of caution and just repeated
the pattern.
As it turned out, someone later changed those methods from "Void" to "void"
and so I ended up doing so in my sandbox (but haven't yet pushed the changes).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
