Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1278#discussion_r49552290
  
    --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
    @@ -509,7 +511,9 @@ public DomainRouterVO deployRouter(final 
RouterDeploymentDefinition routerDeploy
     
                 if (startRouter) {
                     try {
    -                    router = startVirtualRouter(router, 
_accountMgr.getSystemUser(), _accountMgr.getSystemAccount(), 
routerDeploymentDefinition.getParams());
    +                    final Account caller = 
CallContext.current().getCallingAccount();
    --- End diff --
    
    @GabrielBrascher Extracting those lines in a method will remove the 
contextual information from them and will impact the understanding in future so 
it is done this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to