Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1319#discussion_r49498772
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -476,6 +476,25 @@ public VolumeVO doInTransaction(TransactionStatus
status) {
});
}
+ /**
+ * Retrieves the volume name from CreateVolumeCmd object.
+ *
+ * If the retrieved volume name is null, empty or blank, then A random
name
+ * will be generated using getRandomVolumeName method.
+ *
+ * @param cmd
+ * @return Either the retrieved name or a random name.
+ */
+ public String getVolumeNameFromCommand(CreateVolumeCmd cmd) {
+ String userSpecifiedName = cmd.getVolumeName();
+
+ if
(org.apache.commons.lang.StringUtils.isBlank(userSpecifiedName)) {
--- End diff --
Cool...then it all looks good to me.
Unfortunately, at the time being, I have my dev system in a state that
would make it difficult and time consuming for me to test this.
If you do require a tester, please let me know. It might take a few days,
though, before I finish up my current project and can put this code on my
system.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
