Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-170508275
Hi @koushik-das
Your questions were rhetorical and hence not valid because I did not
disagree with you in terms of refactor. I asked you to help testing, which you
partially did. But not having a test environment and relying on a simulator for
everything seems a bit naive for me. You might remember that we had many
problems when people did LGTM PRs based on the Travis results, which are not
reliable.
As I wrote on Saturday, I was going to test again - with the changes - and
post the result, which I did. I will now retest in a clean DC without the
commit - GC related - and post the results. We all expect it to pass, of
course. But if it doesn't we need to find out why the "agnostic" nature of the
implementation is broken.
We could talk for hours and disagree only on things being agnostic within
ACS. I have a few cases in my sleeve. But let's not start again.
Don't give up and say it's useless. At the end we will learn something
anyway, even from rants on github.
By the way, the ```smoke/test_routers.py``` tests were executed by
@remibergsma as well.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
