Github user michaelandersen commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1276#discussion_r48286045
  
    --- Diff: 
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
    @@ -916,6 +916,9 @@ protected void updateSite2SiteVpnConnectionState(final 
List<DomainRouterVO> rout
                     }
                     continue;
                 }
    +            if (router.getIsRedundantRouter() && 
router.getRedundantState() != RedundantState.MASTER){
    --- End diff --
    
    Not per se, as the previous if statement skips the iteration if the router 
to be checked is not in a running state. And running state is required to do 
any further state checking. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to