+1 If moving to Github means we can use all features without restrictions: labels, issues, editing and merging PRs, wiki, integrations, hooks etc etc.
@René, I disagree with testing based on complexity. You simply cannot know the implications upfront, as that is why you run the tests. What seems small, can break it all. Example: This commit seems an easy_fix, right? Just a findbugs issue resolved. https://github.com/apache/cloudstack/commit/6a4927f660f776bcbd12ae45f4e63ae2c2e96774 It was just merged indeed, exactly as you propose. But it did cause a major outage. And I don’t even use HyperV. Details: https://github.com/apache/cloudstack/pull/761 This is why all PRs to 4.6 and 4.7 (200+) that we merged over the last couple of months were tested against a real cloud. No easy fixes and minor changes. We always need to run the full integration tests. When new functionality is proposed, there aren’t many people willing to write unit and integration tests to cover it. Until that changes, testing can only guard whatever the tests cover. And when we merge new stuff without tests, the total coverage goes down making the tests less relevant. In fact, when we resolve a bug we should write a tests along with it. I know of one guy that does that on a regular basis. It’s not so simple as it seems unfortunately. Regards, Remi > >Rating complexity of changes: easy_fix, minor_change, major_change > >Running tests according complexity: > >- easy_fix: just merge it. >- minor_change: unit and simulator test passed >- major_change: the full blown integration testing > >IMHO we should work on solid testing and development is fun, merging a >click and releasing a breath. > >Just my 2 cents. > >Regards >René > > > > >
