Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1083#discussion_r45335326
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreS3CMD.java
---
@@ -201,15 +209,15 @@ public int hashCode() {
result = 31 * result + (secretKey != null ? secretKey.hashCode() :
0);
result = 31 * result + (endPoint != null ? endPoint.hashCode() :
0);
result = 31 * result + (bucketName != null ? bucketName.hashCode()
: 0);
- result = 31 * result + (httpsFlag != null && httpsFlag == true ? 1
: 0);
+ result = 31 * result + (signer != null ? signer.hashCode() : 0);
--- End diff --
The same here: would be nice to move hashCode() and equals() methods to the
end of the file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
