Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/935#discussion_r45038824
  
    --- Diff: 
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/nicira/ControlClusterStatus.java
 ---
    @@ -84,4 +89,17 @@ public int getActiveCount() {
             }
     
         }
    +
    +    public class ClusterRoleConfig {
    --- End diff --
    
    Do those inner classes need to be public?
    
    It's also something we can fix after the merge, unless there is a reason 
for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to