Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1059#discussion_r44523082
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1015,7 +1015,7 @@ protected void updateRoutersRedundantState(final
List<DomainRouterVO> routers) {
RedundantState state = RedundantState.UNKNOWN;
if (answer != null && answer.getResult()) {
state = answer.getState();
- } else {
+ } else if (answer != null) {
s_logger.info("Agent response doesn't seem to be
correct ==> " + answer.getResult());
}
--- End diff --
trivial comment: looks like
```
if (answer != null) {
if (answer.getResult()) {
state = answer.getState();
} else {
s_logger.info("Agent response doesn't seem to be correct ==> " +
answer.getResult());
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
