So Rajani, you suggest to remove the automatic trigger and leave that to reviewer. Sound fine to me.
On Fri, Oct 30, 2015 at 7:35 AM, Rajani Karuturi <raj...@apache.org> wrote: > Thats a good idea. I have seen other open source projects do it this way. > (example: netty project) > On demand build is a better way than doing for every commit change. > > especially when the code reviews are going on or there is WIP, its not > intended to do a build on every commit or update. (The commit could just be > a change in commit message) > > when the contributor is ready, he can call jenkins to verify it by just > commenting @jenkins build > once the code comments(if any) are addressed, we can ask it to build again. > > ~Rajani > > On Thu, Oct 29, 2015 at 7:41 PM, Remi Bergsma <rberg...@schubergphilis.com > > > wrote: > > > Hi all, > > > > Just had a chat with Miguel. > > He showed me that if we setup Github to notify Jenkins on “issue > comments” > > (next to “pull requests” we have now) and then set a “trigger phrase” in > > Jenkins, we could automatically trigger a new build by typing “go build”. > > No more need to force push commits by the author. > > > > Shall we set this up? Can we do this David? > > > > Regards, > > Remi > > > > > > From: Remi Bergsma > > Date: Thursday 29 October 2015 08:47 > > To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" > > Subject: Jenkins failures > > > > Hi, > > > > Can someone please look why Jenkins fails so often recently? It feels > like > > a casino and slows down merging of PRs since we want to merge when they > > “are green”. This requires forse pushing many times now, including the > wait. > > > > I’d prefer not to start ignoring them.. > > > > Thanks for the help! > > > > Regards, > > Remi > > > > > -- Daan
