Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/818#discussion_r43429125
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkVO.java ---
@@ -616,7 +616,8 @@ public void setStrechedL2Network(boolean
strechedL2Network) {
this.strechedL2Network = strechedL2Network;
}
- public void setVpcId(Long vpcId) {
- this.vpcId = vpcId;
- }
+ public void setVpcId(Long vpcId) { this.vpcId = vpcId;}
+
+ public void setIsReduntant(boolean reduntant){this.isRedundant =
reduntant;}
--- End diff --
I think this fragment should look like
public void setVpcId(Long vpcId) {
this.vpcId = vpcId;
}
public void setIsReduntant(boolean reduntant) {
this.isRedundant = reduntant;
}
Why did you change the format of the existing function this way. It does
not adhere to best practice standard code formatting rules.
please change this. we need a force push and rebuild anyway to see a
jenkins output for this old PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
