Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/935#issuecomment-150145949
  
    @nvazquez PR looks awesome now. Great work!
    
    I will pull in your PR and run the marvin test we already have against it 
to see if that is still good. I will post the results in here.
    However, I do not have an environment with vSphere to test one. Could you 
please run the tests we have already on you environment and post the results 
here?
    
    In addition, to make this PR super awesome, we would also need at least one 
new marvin test that exercises the new logic you have introduced. That is, a 
test where the Nicira plugin is configured for vSphere, and we can at least 
create te a VM on a Nicira backed network.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to