Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42446365
--- Diff: framework/db/src/com/cloud/utils/db/Transaction.java ---
@@ -59,4 +59,30 @@ public T doInTransaction(TransactionStatus status)
throws RuntimeException {
});
}
+ @SuppressWarnings("deprecation")
+ public static <T, E extends Throwable> T execute(final short
databaseId, TransactionCallbackWithException<T, E> callback) throws E {
--- End diff --
``public static <T, E extends Throwable> T
execute(TransactionCallbackWithException<T, E> callback) throws E`` should be
implemented in terms of this method. There is a tremendous amount of code
duplication between the two methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
