Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/921#discussion_r41705286
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -509,7 +509,7 @@ private String extract(Account caller, Long templateId,
String url, Long zoneId,
for (DataStore store : ssStores) {
tmpltStoreRef =
_tmplStoreDao.findByStoreTemplate(store.getId(), templateId);
if (tmpltStoreRef != null) {
- if (tmpltStoreRef.getDownloadState() ==
com.cloud.storage.VMTemplateStorageResourceAssoc.Status.DOWNLOADED) {
+ if (tmpltStoreRef.getDownloadState() ==
com.cloud.storage.VMTemplateStorageResourceAssoc.Status.DOWNLOADED &&
tmpltStoreRef.getDownloadPercent() == 100) {
--- End diff --
@yvsubhash thanks for the patch.
Can we address this (add this check) while setting the download state to
DOWNLOADED? That way unless download progress is 100%, the template would not
move to DOWNLOADED state.
Also good add a unit here, checking if template download progress is 100 if
template state is DOWNLOADED.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
