Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/909#issuecomment-145381656
Tested everything I tested in PR #885 again in this PR. @dahn already run
the tests, I verified the functionality manually by destoying VMs out-of-band
and see how it recovers. It works well.
Logs:
```
2015-10-04 19:07:06,168 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-5:null) Detected missing VM. host: 1, vm id: 4, power
state: PowerReportMissing, last state update: 1443985566000
2015-10-04 19:07:06,168 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-5:null) vm id: 4 - time since last state update(60167ms)
has not passed graceful period yet
2015-10-04 19:07:06,169 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-5:null) Detected missing VM. host: 1, vm id: 6, power
state: PowerReportMissing, last state update: 1443985566000
2015-10-04 19:07:06,169 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-5:null) vm id: 6 - time since last state update(60167ms)
has not passed graceful period yet
2015-10-04 19:08:06,542 INFO [c.c.v.VirtualMachineManagerImpl]
(AgentManager-Handler-10:null) VM i-2-6-VM is at Running and we received a
power-off report while there is no pending jobs on it
2015-10-04 19:08:06,542 INFO [c.c.v.VirtualMachineManagerImpl]
(AgentManager-Handler-10:null) Detected out-of-band stop of a HA enabled VM
i-2-6-VM, will schedule restart
2015-10-04 19:08:06,557 INFO [c.c.h.HighAvailabilityManagerImpl]
(AgentManager-Handler-10:null) Schedule vm for HA: VM[User|i-2-6-VM]
2015-10-04 19:08:06,557 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-10:null) Done with process of VM state report. host: 1
2015-10-04 19:08:06,601 INFO [c.c.h.HighAvailabilityManagerImpl]
(HA-Worker-1:ctx-f0996892 work-2) Processing work
HAWork[2-HA-6-Running-Investigating]
2015-10-04 19:08:06,603 INFO [c.c.h.HighAvailabilityManagerImpl]
(HA-Worker-1:ctx-f0996892 work-2) HA on VM[User|i-2-6-VM]
2015-10-04 19:09:07,022 DEBUG [c.c.v.VirtualMachineManagerImpl]
(Work-Job-Executor-9:ctx-1278576b job-36/job-38 ctx-21e14d55) Start completed
for VM VM[User|i-2-6-VM]
2015-10-04 19:20:38,647 INFO [c.c.v.VirtualMachineManagerImpl]
(AgentManager-Handler-10:null) Detected out-of-band stop of a HA enabled VM
s-2-VM, will schedule restart
2015-10-04 19:20:38,838 INFO [c.c.h.HighAvailabilityManagerImpl]
(HA-Worker-2:ctx-379f80bc work-11) Processing work
HAWork[11-HA-2-Running-Investigating]
2015-10-04 19:20:38,840 INFO [c.c.h.HighAvailabilityManagerImpl]
(HA-Worker-2:ctx-379f80bc work-11) HA on VM[SecondaryStorageVm|s-2-VM]
2015-10-04 19:20:38,841 INFO [c.c.h.HighAvailabilityManagerImpl]
(AgentManager-Handler-10:null) Schedule vm for HA:
VM[SecondaryStorageVm|s-2-VM]
2015-10-04 19:20:38,891 INFO [c.c.h.HighAvailabilityManagerImpl]
(HA-Worker-2:ctx-379f80bc work-11) SimpleInvestigator found
VM[SecondaryStorageVm|s-2-VM] to be alive? false
2015-10-04 19:24:28,759 DEBUG [c.c.v.VirtualMachineManagerImpl]
(Work-Job-Executor-12:ctx-49cc4b77 job-40/job-42 ctx-b7bd08fc) Start completed
for VM VM[SecondaryStorageVm|s-2-VM]
```
A router, a user instance and a system vm were tested and recovered fine.
I make my LGTM of the previous one also count here: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
