Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r38917337
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4751,7 +4760,7 @@ private VirtualMachineGuestOsIdentifier
translateGuestOsIdentifier(String cpuArc
}
}
}
- vmResponseMap.put(name, new
VmStatsEntry(Integer.parseInt(maxCpuUsage), networkReadKBs, networkWriteKBs,
Integer.parseInt(numberCPUs), "vm"));
+ vmResponseMap.put(name, new
VmStatsEntry(Double.parseDouble(memkb)*1000,Double.parseDouble(guestMemusage)*1000,Double.parseDouble(memlimit)*1000,
Double.parseDouble(maxCpuUsage), networkReadKBs, networkWriteKBs,
Integer.parseInt(numberCPUs), "vm"));
--- End diff --
Is there a possibility that one of the values is not returned and hence can
be null? calling parseDouble on a null value will throw NPE
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
