Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/772#issuecomment-138483590
Hi @jayapalu @remibergsma @miguelaferreira @DaanHoogland
I executed the tests mentioned about. Results below:
VPN remote access user limit tests ... === TestName: test_01_VPN_user_limit
| Status : SUCCESS ===
ok
Test create VPN when L2TP port in use ... === TestName:
test_02_use_vpn_port | Status : SUCCESS ===
ok
Test create NAT rule when VPN when L2TP enabled ... === TestName:
test_03_enable_vpn_use_port | Status : SUCCESS ===
ok
Test add new users to existing VPN ... === TestName: test_04_add_new_users
| Status : SUCCESS ===
ok
Test add duplicate user to existing VPN ... === TestName:
test_05_add_duplicate_user | Status : SUCCESS ===
ok
Test as global admin, add a new VPN user to an existing VPN entry ... ===
TestName: test_06_add_VPN_user_global_admin | Status : SUCCESS ===
ok
Test as domain admin, add a new VPN user to an existing VPN entry ... ===
TestName: test_07_add_VPN_user_domain_admin | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 7 tests in 2483.901s
OK
/tmp//MarvinLogs/test_vpn_users_Z7SW61/results.txt (END)
Test VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status :
SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
----------------------------------------------------------------------
Ran 2 tests in 1560.555s
OK
/tmp//MarvinLogs/test_vpc_vpn_LXRLZL/results.txt (END)
I also had a look at the tests code in order to see if they are covering
real cases. For the test user, it doesn't really check connection availability.
It's more about the users, as the name suggested.
Concerning the VPC VPN, it tests quite a lot. It creates a VPC and adds 1
VM to it, then it creates a VPN on the source nat IP and adds 1 VPN user to it.
It doesn't test connection though. That would have to be done manually or we
have to write a Python VPN client connection inside the test code.
In respect to the test_vpc_site2site_vpn test, it creates 2 VPCs, 2
networks, 2 VMs and 2 VPNs - on each source nat ip address. The cool thing is
that the test connects the VPCs to each other, so testing the VPN connection in
this case.
Would that cover your changes, @jayapalu ?
What do you think, @remibergsma @miguelaferreira @DaanHoogland ?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
