Hi,
Please find the latest report on new defect(s) introduced to cloudstack found
with Coverity Scan.
1 new defect(s) introduced to cloudstack found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1323172: Null pointer dereferences (NULL_RETURNS)
/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java:
412 in
org.apache.cloudstack.storage.snapshot.SnapshotServiceImpl.revertSnapshot(org.apache.cloudstack.engine.subsystem.api.storage.SnapshotInfo)()
________________________________________________________________________________________________________
*** CID 1323172: Null pointer dereferences (NULL_RETURNS)
/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java:
412 in
org.apache.cloudstack.storage.snapshot.SnapshotServiceImpl.revertSnapshot(org.apache.cloudstack.engine.subsystem.api.storage.SnapshotInfo)()
406
407 }
408
409 @Override
410 public boolean revertSnapshot(SnapshotInfo snapshot) {
411 SnapshotInfo snapshotOnPrimaryStore =
_snapshotFactory.getSnapshot(snapshot.getId(), DataStoreRole.Primary);
>>> CID 1323172: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "snapshotOnPrimaryStore".
412 PrimaryDataStore store =
(PrimaryDataStore)snapshotOnPrimaryStore.getDataStore();
413
414 AsyncCallFuture<SnapshotResult> future = new
AsyncCallFuture<SnapshotResult>();
415 RevertSnapshotContext<CommandResult> context = new
RevertSnapshotContext<CommandResult>(null, snapshot, future);
416 AsyncCallbackDispatcher<SnapshotServiceImpl, CommandResult>
caller = AsyncCallbackDispatcher.create(this);
417
caller.setCallback(caller.getTarget().revertSnapshotCallback(null,
null)).setContext(context);
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/cloudstack?tab=overview
To manage Coverity Scan email notifications for "dev@cloudstack.apache.org",
click
https://scan.coverity.com/subscriptions/edit?email=dev%40cloudstack.apache.org&token=494aabd5ba647999fa41b6d766646231
