Github user milamberspace commented on the pull request:

    https://github.com/apache/cloudstack/pull/749#issuecomment-135552489
  
    
    The root cause of this issue is the missing comma after the backslash in 
the pt_BR translation.
    
    See this key/value on source messages.properties:
    
    message.admin.guide.read=For VMware-based VMs, please read the dynamic 
scaling section in the admin guide before scaling. Would you like to continue?\,
    
    
    Generally, the translators on Transifex don't changes the 'special' 
characters on source language, thus the BR translation (and others languages) 
must included the backslash in the localization sentence.
    
    But in the case of Portuguese (Brazil) localization, the translator has 
missed the comma at the end of the sentence (unlike the source language). (the 
language like French (my native) is good, on master or 4.5, because the comma 
at the end exists)
    
    The correct fix is:
    
    1/ Fix on Transifex (else, next time when I will update the L10N properties 
files, your changes will be erased)
    2/ Download the new l10n properties from Transifex (all languages or only 
the language with issue)
    3/ Make the PR
    4/ Wait the 2 LGTM (if possibly with me, because I follow the L10N process 
on CloudStack (important for me))
    5/ Commit/Merge the PR
    
    You can have some information on the L10N here:
    
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Update+L10N+files+from+Transifex+to+git+repo
    
    @bhaisaab  I can fix this issue on Transifex (and check for all languages 
if the comma is missing) and purpose a new PR to (re)fix this issue, Or if you 
want fix them, free you as felling.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to