On Wed, Aug 26, 2015 at 10:03 AM, Wido den Hollander <w...@widodh.nl> wrote: > > > On 08/26/2015 03:53 PM, Remi Bergsma wrote: >> Hi Rohit, >> >> Thanks for sharing your observations. I agree with you that anybody that >> contributes (or uses) Apache CloudStack should feel welcome in the community. >> >> In the past weeks I tried to respond to as many PRs as I could and merge >> them as soon as it met the requirements. When I can not review myself, I >> usually ping someone and ask to do the review. This way I hope new >> contributors too get a fast response. I agree this is important so let us >> all have a look at the PRs on a regular basis and review them if possible. >> >> Also, I dropped the closing of PRs for now. I get your point and propose to >> leave it as-is. It’s not important now. >> >> I see a master that gets more stable every day and I think that’s awesome. >> Also for new contributors or new users this is great, as most new devs will >> checkout master to see if it is any good. In the current state, I’d say we >> improved greatly. >> > > And that's something that makes me happy. In the past we had tons of > broken code coming into master which made development against master > painful. Very painful. > > We indeed slow development down now, but I think that is a good thing at > this point. We need to stabilize a lot. >
I don't see it as slowing down development, I see it as accelerating stability. Our feature releases arrive every few months, so waiting a few days, or even weeks, is not a huge imposition if in return we garner a more stable master. >> So, it’s true that our review process takes time and effort, but IMHO it’s >> worth it. Running tests before anything hits master shows us problems in >> advance. And in case it doesn’t, we can always go ahead and improve the >> tests. >> > At the end of the day, new (and old) contributors want to know that someone cares about their contribution. The problem we have to solve is not losing track of open PRs. To that end, is it worth having a weekly hack session on IRC where we can actively review open PRs and chase them to completion? What else can we do to continue shining light on PRs? --David
