Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-132335229
@pedro-martins s_logger is a standard name for the variables and in each
class it gets the <class>.class as its log category. I fail to see how you
change improves on this.
Also '4,076 additions and 3,379 deletions' means more code and not a
reduction in code.
Finally I see a lot of reordering of variables in classes that I'd rather
see in separate commits so the essentials of your change are easier reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
