Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-131212079
@DaanHoogland I agree, we should only squash if there is no value to have
the commits separated. I usually ask for squashing when feedback was processed
in a separate commit (say remove a comment or fix a small thing). That you want
squashed so it becomes an atomic commit. If commits are already atomic, I'm OK
with not squashing. It's your call here ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
