Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-128843113
@devdeep You have written a very fine test and as it passes and tests what
its target should do you would get a definate lgtm on tat one from me. However
it does not test the code that was changed in this PR so it should be submitted
separately and the code here should be tested in this PR.
let's ask the RMs, @remibergsma and @karuturi. If they think it is fine to
add it like this I will let them. The code looks ok but the PR doesn't to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
