Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34872122
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super(MerovingianMBean.class, false);
_msId = msId;
- Connection conn = null;
- try {
- conn =
TransactionLegacy.getStandaloneConnectionWithException();
+ try (Connection conn =
TransactionLegacy.getStandaloneConnectionWithException();) {
--- End diff --
yes, you are right. it needs to be addressed though. I think the close
should then happen in the catch instead of automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
