Hi Daan, > On 29-Jun-2015, at 4:45 pm, Daan Hoogland <daan.hoogl...@gmail.com> wrote: > > Rohit, I guess this was your saml merge, Can you fix (parameterizing > getBytes() with either StringUtils.getPreferredEncoding() or > Charset.defaultCharset(), depending on what you considder applicable)?
Yes, look like findbugs detected 4 default encoding issues in SAMLUtils.java - I’ll fix them. > About the upgrade; I would wait untill 4.5.2 is out. We don't want > stale upgrades in the codebase, do we? Might be a bit pedantic as we > know it is the next thing we'll do but still. My assumption was 4.5.2 is likely to get released before 4.6.0 would. I plan to start with bugfix and release efforts in next 1-2 weeks, this week I’m trying to hear from the community and users who are on 4.5.1 and would want few issues addressed in 4.5.2. Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/> CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/> This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
